Conversation
zhming0
commented
Apr 4, 2025
zhming0
force-pushed
the
ming/te-3588
branch
3 times, most recently
from
7bfec10 to
8e6a67f
Compare
niceking
reviewed
Apr 4, 2025
|
|
||
| COLLECTOR_NAME='buildkite-test-collector' | ||
| VERSION='1.0.1rc1' | ||
| VERSION='1.0.1' |
There was a problem hiding this comment.
Is this right? This is a general release? Have you confirmed it works for the customer?
Contributor
Author
There was a problem hiding this comment.
fair point, I changed to rc2
niceking
approved these changes
Apr 4, 2025
niceking
left a comment
niceking
left a comment
There was a problem hiding this comment.
Don't really understand the full context of this PR or python but as its a rc let's get the customer to try it out!
| # Strictly speaking, we do not need this hook. | ||
| # But in pytest it's hard to predict how plugins interfere each other. | ||
| # So let's be defensive here. | ||
| # If pytest_runtest_makereport runs properlly then this hood is unnecessary. |
There was a problem hiding this comment.
Suggested change
| # If pytest_runtest_makereport runs properlly then this hood is unnecessary. | |
| # If pytest_runtest_makereport runs properly then this hook is unnecessary. |
zhming0
force-pushed
the
ming/te-3588
branch
2 times, most recently
from
4ce5338 to
d1dc719
Compare
zhming0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered that
xdistdoesn't work with our1.0.0version, the reason can be summarize in one sentence: when xdist is enabled, some hooks will get totally ignored.But the fix is not so simple, because there isn't an official document saying which hooks will be skipped under what situation. So after a lot of experiments, I come to the following change:
pytest_runtest_makereportto replacepytest_runtest_teardownhook (this gets totally skipped byxdist).BUILDKITE_ANALYTICS_DEBUG_ENABLEDas debug envvar instead of the generalDEBUGenv var.I have tested extensively in my local env, can confirm this work with or without
xdist.