Merged
Conversation
This is a Test Engine `run_env`; for a “Run” in Test Engine.
There was a problem hiding this comment.
Pull Request Overview
This PR renames the RuntimeEnvironment class and all its references to RunEnv to streamline naming across the codebase.
- Renamed the
RuntimeEnvironmentclass and updated imports in source and test files - Updated function signatures and return types to use
RunEnv - Adjusted variable names and type hints in tests to match the new class name
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/buildkite_test_collector/conftest.py | Updated import and fixture return type to RunEnv |
| tests/buildkite_test_collector/collector/test_run_env.py | Replaced runtime_env references with run_env |
| src/buildkite_test_collector/collector/run_env.py | Renamed class, functions, and updated module docstring |
| src/buildkite_test_collector/collector/payload.py | Updated import and type annotations to RunEnv |
Comments suppressed due to low confidence (3)
src/buildkite_test_collector/collector/run_env.py:1
- [nitpick] The module-level docstring is terse and doesn’t describe its purpose clearly. Consider expanding it to explain that this module detects and represents CI run environments for the test engine.
"""Test Engine run_env"""
src/buildkite_test_collector/collector/run_env.py:94
- [nitpick] The class docstring
The detected RunEnvis tautological. You may want to expand it to explain what fields this class provides and how it’s used to represent CI environment data.
class RunEnv:
src/buildkite_test_collector/collector/run_env.py:20
- Module-private functions are usually prefixed with a single underscore. Consider renaming
__buildkite_env(and other double-underscore helpers) to_buildkite_envto follow PEP 8 conventions.
def __buildkite_env() -> Optional['RunEnv']:
tommeier
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Test Engine
run_env; for a “Run” in Test Engine.