Fix Windows installer to perform in-place upgrades#2
Open
Conversation
…-side installs The NSIS script embedded TRACE_VERSION in the install directory, registry keys, shortcuts, file associations, and mutex name. This caused each new version to install as a separate application (e.g. C:\Program Files\Trace\1.1.0\ and C:\Program Files\Trace\1.2.0\) instead of upgrading in-place. Changes: - Remove version from MULTIUSER_INSTALLMODE_INSTDIR (Trace\1.2.0 -> Trace) - Remove version from registry uninstall key (Trace 1.2.0 -> Trace) - Remove version from PRODUCT_UNINST_KEY, SMPATH, shortcuts, file associations, AppModelId, and installer mutex - Add RemoveOldVersionedInstalls migration that detects and silently removes old versioned installations (1.0.0, 1.1.0, 1.2.0) via registry lookup, silent uninstall, and stale directory/shortcut cleanup - Keep version in MULTIUSER_INSTALLMODE_DISPLAYNAME for Add/Remove Programs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRACE_VERSIONin install path (Trace\1.2.0), registry keys (Trace 1.2.0), shortcuts, file associations, and mutex — causing each version to install as a completely separate application instead of upgrading in-placeC:\Program Files\Trace\RemoveOldVersionedInstallsmigration function that runs on install to detect and silently remove old versioned installations (1.0.0, 1.1.0, 1.2.0) via registry lookup + silent uninstall + stale directory/shortcut cleanupTest plan
C:\Program Files\Trace\1.2.0\)C:\Program Files\Trace\(no version subfolder)TracenotTrace 1.3.0TracenotTrace 1.3.0