QDB-17652 - Add support for Python 3.14 #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Python 3.14 by addressing a breaking change in multiprocessing behavior and updating version parsing logic. Python 3.14 changed the default process spawning method from "fork" to "forkserver" on POSIX systems, which breaks existing tests.
- Explicitly set multiprocessing to use "fork" method to maintain test compatibility
- Add Python 3.14 version parsing support in Docker configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_firehose.py | Modified to explicitly use fork context for multiprocessing to maintain compatibility with Python 3.14 |
| docker/set-python-version.sh | Added version parsing case for Python 3.14 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+27
to
+28
| # way of starting process on Linux changed in python 3.14 from fork to forkserver: https://github.com/python/cpython/issues/84559 | ||
| # to keep this test working on newer python versions we specify the "fork" method explicitly |
There was a problem hiding this comment.
Corrected spelling of 'OS'es' to 'OSes' in the comment.
Contributor
|
Is this working on all agents ? |
Contributor
Author
|
Yes, working on all agents. Ran composite for debug and release with only errors coming from flaky stats by node test. |
solatis
approved these changes
Oct 15, 2025
igorniebylski
deleted the
sc-17652/add-build-configuration-for-python-3-14-to-teamcity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.14 multiprocessing changed the way processes are spawned on POSIX OSes
For python < 3.14 multiprocessing used fork
For python >= 3.14 multiprocessing uses forkserver
more info python/cpython#84559
with forkserver the child process does not inherit the parent's resources
this change breaks the test because the child process cannot access the iterator
i set usage of fork explicitly to keep the test working
Build: http://teamcity.cicd.intra.quasar.ai:8111/buildConfiguration/Api_Python_Composite/1057870