QDB-16178 - Refactor python statistics module #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6178/refactor-python-statistics-module-to-make-use
Reuses venv, reuses `build/` directory
…ython-api' into sc-16178/refactor-python-statistics-module-to-make-use
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the Python statistics module and its tests. Key changes include updating the logic in statistics retrieval functions in quasardb/stats.py, refactoring the polling mechanism in tests/test_stats.py, and deprecating the stat_type API with a warning notice.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_stats.py | Updates to the _ensure_stats polling logic and test setup |
| quasardb/stats.py | Refactoring of key retrieval, indexing, and metric type/unit lookup |
Files not reviewed (1)
- scripts/tests/setup: Language not supported
Comments suppressed due to low confidence (1)
quasardb/stats.py:101
- The 'stat_type' function now only issues a deprecation warning and does not return any value, which could break existing usage that expects a stat type. Consider returning the legacy value or updating consumers to use the new API.
def stat_type(stat_id):
solatis
added a commit
that referenced
this pull request
May 8, 2025
Makes use of the new server-side metric type/units, and changes the way statistics are exposed. This is a breaking change for users who previously used the statistics API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.