-
Notifications
You must be signed in to change notification settings - Fork 0
QDB-16714 - Dask integration into Python API #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
68fb3a8
f584699
8cb2641
0520247
75f9619
5999a68
3d47e06
24b990f
3cd86c1
690d4df
c2cbb04
5726dbb
6c16b28
825dcd1
13b47ee
7fe2ebe
456c587
752d83d
179cb19
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -764,10 +764,15 @@ def deduplication_mode(request): | |
| return request.param | ||
|
|
||
|
|
||
| @pytest.fixture(params=["S"], ids=["frequency=S"]) | ||
| def frequency(request): | ||
| yield request.param | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def gen_index(start_date, row_count): | ||
| def gen_index(start_date, row_count, frequency): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is gen_index invoked? Would it not require a default value for this parameter? Did you check the tests pass?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its a leftover from test_dask.py
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for test_dask.py i needed to have data split between multiple shards
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I get it, it's a fixture and we have a separate Please keep conftest.py as in-sync as possible with the one in our dask repository.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, i will update conftest in |
||
| return pd.Index( | ||
| pd.date_range(start_date, periods=row_count, freq="S"), name="$timestamp" | ||
| pd.date_range(start_date, periods=row_count, freq=frequency), name="$timestamp" | ||
| ) | ||
|
|
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is not too useful right now, I assume you do the regex part in the dask connector now, which is probably not ideal.
Let's keep it as-is though.