Track errors across all forms and provide feedback via messages to user.#118
Open
derek-richard wants to merge 17 commits intoburke-software:masterfrom
Open
Track errors across all forms and provide feedback via messages to user.#118derek-richard wants to merge 17 commits intoburke-software:masterfrom
derek-richard wants to merge 17 commits intoburke-software:masterfrom
Conversation
|
It would be amazing if this change could be merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be difficult for users to see what the underlying problem is when a mass edit fails. Often, its because the data is not correctly supplied to a form. In one case I had, tracking all the form messages allowed me to find an "edge case" in the model's
clean()function that was preventing the mass edit completing properly.The proposed patch does not change any of the core logic but only adds an extra tracking functionality so users can get feedback on any failures via Django's messaging framework.