Add argument to use custom configuration#34
Merged
iurisilvio merged 2 commits intobusinho:mainfrom Jun 19, 2025
hasier:custom-config
Merged
Add argument to use custom configuration#34iurisilvio merged 2 commits intobusinho:mainfrom hasier:custom-config
iurisilvio merged 2 commits intobusinho:mainfrom
hasier:custom-config
Conversation
Contributor
Author
|
@iurisilvio sorry for the direct ping, I've seen you've merged most of the recent changes, any chance you could take a look at this one? Hopefully it's an interesting one to include in the library 🙏 |
iurisilvio
approved these changes
Jun 19, 2025
Contributor
|
Thanks for the contribution! Sorry for the delay! Merged and released in v0.5! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks for building this plugin, I've found it very useful!
Currently I am working on a monorepo setup, which means I work with a hierarchy of folders with different packages. In order to keep some consistency, it'd be great if I could parametrise the input config for the plugin, which is what I am attempting to do in this PR.
I took some inspiration from
pytest-mypyto build the way the config is injected into the plugin.Hope this makes sense, let me know if you'd prefer to do it in a different way!