Added options object. Specify gulpRelative path.#16
Open
mccambridge wants to merge 1 commit intobustardcelly:masterfrom
Open
Added options object. Specify gulpRelative path.#16mccambridge wants to merge 1 commit intobustardcelly:masterfrom
mccambridge wants to merge 1 commit intobustardcelly:masterfrom
Conversation
… for root relative files to consider them gulpfile-relative
Author
|
looks like you might want to update your node version ;) |
|
Thanks for this fix @mccambridge, I hope you're planning on leaving your repo up, I'm hotlinking it until this is merged. 😁 Would this fix require node v4 in order to run if you're using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the same issue a lot of people were having. If I specified a root-relative path in my html, the assets weren't being found and the script errored out.
I created an
optionsobj that allows you to specify agulpRelativeflag, where the script takes a root-relative path and appends it to the pwd. Now it finds the assets even if your html is located in a different directory than the gulpfile. Assets get hashed. Much win.Fixes: #5 ... maybe others
Cheers!