basePath & regExp now can be configured#9
Open
StyleT wants to merge 1 commit intobustardcelly:developfrom
Open
basePath & regExp now can be configured#9StyleT wants to merge 1 commit intobustardcelly:developfrom
StyleT wants to merge 1 commit intobustardcelly:developfrom
Conversation
Author
|
Anyone is here? |
Owner
|
I appreciate your interest and this PR. I am currently deciding on the relevance of its improvement for the following reasons:
Truthfully, it's Number 2 that really is keeping me from accepting this PR (along with no additional test to ensure that the changes do what they propose). I use gulp-replace quite often and I think it would be a better tool in what this PR may be trying to accomplish. I do appreciate your work and would like to hear your thoughts to make me change my mind. I also apologize for the late response; life happens :) |
|
+1 for the PR! I need it because I am moving the html from the src to the dist folder, and in src there are not the compiled files to which the html refers (I am using typescript and stylus). |
5d6ea32 to
db920e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now user can specify base path or regular expression