Enabled drag & drop to an empty section#12
Open
eltonf wants to merge 3 commits intobvogelzang:masterfrom
Open
Conversation
…header) In the original implementation it's impossible to drag & drop a cell into an empty section since the logic looks for an adjacent cell to derive an NSIndexPath. Because an empty section does not have any cells the logic looks for the CGRect of the header or footer while dragging the table cell only if it doesn't have a current match for a table cell. When there is a hit for a header or footer the next NSIndexPath is assumed to be section #, row 0 in the section that lacks any table cells.
|
This is a great improvement! Can we take action and make a new PodSpec? There seem to be 6 pending pull requests, yet no changes in 2 years... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous comment was partially incorrect. It appears that a section footer or header is not required for this to work.