Skip to content

feat: add cursor.count() deprecation error #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h3n4l merged 1 commit into from
Jan 19, 2026
Merged

feat: add cursor.count() deprecation error #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions executor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,3 +1890,19 @@ func TestDistinctNumericValues(t *testing.T) {
require.NotNil(t, result)
require.Equal(t, 3, result.RowCount) // 100, 85, 90
}

func TestCursorCountDeprecated(t *testing.T) {
client, cleanup := setupTestContainer(t)
defer cleanup()

ctx := context.Background()

gc := gomongo.NewClient(client)

// cursor.count() is deprecated and should return an error
_, err := gc.Execute(ctx, "testdb", "db.users.find().count()")
require.Error(t, err)
require.Contains(t, err.Error(), "count()")
require.Contains(t, err.Error(), "countDocuments()")
require.Contains(t, err.Error(), "estimatedDocumentCount()")
}
6 changes: 6 additions & 0 deletions translator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,12 @@ func (v *mongoShellVisitor) visitMethodCall(ctx mongodb.IMethodCallContext) {
case "distinct":
v.operation.opType = opDistinct
v.extractDistinctArgs(gmCtx)
case "count":
// cursor.count() is deprecated
v.err = &UnsupportedOperationError{
Operation: "count()",
Hint: "MongoDB drivers deprecate their respective cursor and collection count() APIs in favor of countDocuments() and estimatedDocumentCount()",
}
default:
v.err = &UnsupportedOperationError{
Operation: methodName,
Expand Down