Fix windows crash after success #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing spurious crashes on windows after successful benchmark runs when unloading the dll. Upgrade libloading to the latest as a first step in diagnosing potential problems. This updated version may just fix the issue; if not, it provides a way to do an explicit close() where we can handle errors potentially.
Windows has been exhibiting crashes after completion. We hope to explicilty control dll close in order to either prevent problems or get more explicit information on problems.
Collaborator
Author
|
Windows logs also do not include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spuriously, but more consistently in recent runs, we've seen crashes after successful benchmark runs on Windows. In truth, I don't have a windows PC to easily reproduce and diagnose the crash (reported segfault) that occur but they appeared to be related to lib unloading.
As part of diagnosing the problems I updated libloading to the lastest and added an explicit close() rather than relying on Drop, in part to try to get more info on what might be going wrong. Making the close() explicit seems to make CI happy so submitting this as-is to get CI running again, though I don't have an entirely satisfactory root cause to point to.
Failing CI Runs:
Which have this signature buried in other output from the parent process:
So output from the process writes that all is well but the process exits with code 0xc0000005 indicating an Access Violation under Windows.