Sightglass CLI: allow hyphens in engine flags. #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `--engine-flags '-Ccranelift-...=...'` fails to work because the structopt argument parser sees the `-C...` as a new argument. The `allow_hyphen_values` option allows such usage to work, which is very convenient for running experiments with different optimization options without rebuilding the `.so` with modified defaults.
Collaborator
|
Ah, nice. The workaround I've been using for this is to quote the whole chunk of flags like this: but it would be nice to not have to do that. |
posborne
approved these changes
Dec 22, 2025
fitzgen
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
--engine-flags '-Ccranelift-...=...'fails to work because the structopt argument parser sees the-C...as a new argument. Theallow_hyphen_valuesoption allows such usage to work, which is very convenient for running experiments with different optimization options without rebuilding the.sowith modified defaults.