Add SpiderMonkey JSON/Regex benchmark #305
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--
The new benchmarks are pretty straightforward; the tricker bit here was figuring out an approach I was reasonbly happy with for bundling js inputs into the artifact. In the end, I used the same hex encoded contents in header files approach but with a top-level header pulling in the js code bits.
Adding new JS benchmarks should be fairly simple now with just adding a new directory under benchmarks/spidermnokey/js/ with main.js and other files and then providing the expected named input/stdout/stderr files based on the pattern.
I did consider switching things over to starlingmonkey but decided to leave that alone for now as it didn't appear it would be a straightforward migration and probably doesn't have too much value in practice for what insights we're looking to get from sightglass.
CC @zkat / @TartanLlama