Skip to content

fix(SoundVolume): addVolumeListener callback have same behaviour #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(SoundVolume): addVolumeListener callback have same behaviour #103

wants to merge 1 commit into from

Conversation

@tt-driver-apps
Copy link

@RenaudJenny-TomTom
fix(SoundVolume): addVolumeListener callback have same behaviour
0740cdf 
* Fix SoundVolume addVolumeListener callback have the same behaviour on
Android and iOS
* Fix c19354837#102
* Fix c19354837/issues/102
@tt-driver-apps
Copy link
Author

@c19354837 As mentioned in the issue, we eventually came with the second solution. Meaning we "suspend" listener on iOS part as well, like it's done on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c19354837 c19354837 Awaiting requested review from c19354837

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

addVolumeListener callback doesn't have the same behaviour on Android and iOS

2 participants

@tt-driver-apps @RenaudJenny-TomTom