feat(backend): make backend configurable via environment variables#186
Open
alikhere wants to merge 3 commits intoc2siorg:mainfrom
Open
feat(backend): make backend configurable via environment variables#186alikhere wants to merge 3 commits intoc2siorg:mainfrom
alikhere wants to merge 3 commits intoc2siorg:mainfrom
Conversation
f13791c to
31f0081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every configurable value in the Flask backend was hardcoded in main.py— host, port, debug mode, CORS origins, and output directory path. None of it could be changed without modifying source code directly.
Wired all five values to environment variables using os.environ.get() with the existing hardcoded values as defaults, so behaviour is completely unchanged when no .env is present:
FLASK_HOST/FLASK_PORT/FLASK_DEBUG→app.run()CORS_ORIGINS→CORS(app, origins=...)OUTPUT_DIR→ module-level variable used instart_gdb_session,compile_code, andupload_fileAlso added
gdbui_server/.env.exampledocumenting all five variables, and a short Environment Variables section in README.md.How to test
cp gdbui_server/.env.example gdbui_server/.env && python main.pyFLASK_PORT=9999in.envand restart — server should bind to 9999cd gdbui_server && python -m unittest discover -s . -p 'flask_test.py'Related Issue
Fixes #185