Conversation
Fixed critical bug where WiFi connection attempts would hang indefinitely after requesting a network scan. The issue was caused by mixing async runtimes - using `tokio::time::sleep()` within `glib::MainContext::spawn_local()` tasks, which are incompatible.
Updated README to enhance formatting and add an image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WiFi connection attempts would hang indefinitely after the scan step, preventing users from connecting to any network (open or secured).
I was mixing async runtimes -
tokio::time::sleep()was blocking forever insideglib::MainContext::spawn_local()tasks. These runtimes are incompatible.I replaced all
tokio::time::sleep()calls withfutures_timer::Delayin theconnect()method, which is runtime-agnostic and works with both tokio and glib contexts.Note
Current implementation uses polling with delays. Future PR will refactor to event-driven D-Bus signals for production-quality connection handling. See #46