Skip to content

Conversation

Copy link

Copilot AI commented Nov 30, 2025

Base package URL was not correctly applying the ${variant} suffix for libssl3 distributions due to a typo in the case statement variable.

Changes

  • Fixed case statement to use $deb instead of $dist (the actual loop variable)
  • Corrected variant value from +libssl to +libssl3
  • Added ${variant} suffix to multi package URLs for consistency
# Before: $dist was undefined, variant never set correctly
case "$dist" in
  jammy | noble | plucky | bookworm | trixie) variant=+libssl ;;

# After: uses correct loop variable and variant name
case "$deb" in
  jammy | noble | plucky | bookworm | trixie) variant=+libssl3 ;;

All package URLs (base, multi, ls) now correctly include the variant suffix for distributions requiring libssl3.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on restoring pkg for specific distros Fix variant suffix for libssl3 distributions in fpm.sh Nov 30, 2025
Copilot AI requested a review from tillkruss November 30, 2025 00:38
Copilot finished work on behalf of tillkruss November 30, 2025 00:38
Copy link
Member

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot The variant must be added to app 3 packages entries.

Copy link
Author

Copilot AI commented Nov 30, 2025

@copilot The variant must be added to app 3 packages entries.

Looking at the current code, all 3 deb package entries (base, multi, ls) already include ${variant}:

# base (line 46)
$baseurl-php8.4-debian-${arch_url}${variant}.tar.gz

# multi (line 53)
$baseurl-php$php-debian-${arch_url}${variant}.tar.gz

# ls (line 54)
$baseurl-php$php-debian-${arch_url}${variant}.tar.gz

Could you clarify which entries are missing the variant? Are you referring to the RPM packages (single, multi, ls) which don't currently use a variant suffix?

@tillkruss
Copy link
Member

@copilot the variant must be added as a new parameter to the URL STRING.

Copilot AI requested a review from tillkruss November 30, 2025 00:45
Copilot finished work on behalf of tillkruss November 30, 2025 00:45
@tillkruss tillkruss closed this Nov 30, 2025
@tillkruss tillkruss deleted the copilot/sub-pr-27 branch November 30, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants