fix: avoid eval error by discouraging overzealus module signatures

[blaggacao]

No description provided.

[blaggacao]

Stuff like this:

error: attribute 'pre-commit-hooks' missing

       at /nix/store/h3vlwnvhbkjlck4ps694kmz20jwvgscc-source/lib/modules.nix:483:28:

          482|         builtins.addErrorContext (context name)
          483|           (args.${name} or config._module.args.${name})
             |                            ^
          484|       ) (lib.functionArgs f);
(use '--show-trace' to show detailed location information)
/nix/store/1c147j530hi4p2v5dlpg5x9dm309pivi-source/direnv_lib.s

The following consumption pattern is fixed by this change:

{
  inputs.devenv.url = "github:cachix/devenv?dir=src/modules";
}

[blaggacao]

boah, I guess we need an integration point for services....

error: The option `pre-commit' does not exist. Definition values:
       - In `/nix/store/xyp27kgag9yp8ldix8rsg38wpr0xv1ff-source/src/modules/languages/rust.nix':
           {
             _type = "if";
             condition = false;
             content = {
               tools = {
           ...
(use '--show-trace' to show detailed location information)

[blaggacao]

Uncomfortable, but works:

{
  eval = module: (lib.evalModules {
    modules = [
        (devenv.modules + /top-level.nix)
        {
          disabledModules = []
            ++ (listEntries (devenv.modules + /integrations))
            ++ (listEntries (devenv.modules + /languages))
          ;
        }
        module
    ];
    specialArgs = {
      pkgs = nixpkgs;
      inherit inputs;
    };
  }).config;

Maybe this should become an issue?

[bobvanderlinden]

I like that this makes pre-commit-hooks less special 👍 Makes sense to pass is as an input in specialArgs.

[bobvanderlinden]

Might be good to refer to devenv.yaml, instead of flakes, as that is the default way people are using devenv. The same is done in the Ruby module:

devenv/src/modules/languages/ruby.nix

Lines 6 to 12 in ecd528f

	nixpkgs-ruby = inputs.nixpkgs-ruby or (throw ''
	To use languages.ruby.version or languages.ruby.versionFile, you need to add the following to your devenv.yaml:
	inputs:
	nixpkgs-ruby:
	url: github:bobvanderlinden/nixpkgs-ruby
	'');

[domenkozar]

The issue with this change is that it will break for all users that won't use devenv from master, as soon as they upgrade.

We need to provide backwards compatible way to transition (it should just work for devenv 0.5.1 or lower).

[blaggacao]

Please take over!

[domenkozar]

For anyone that picks this up:

• instructions show should devenv.yaml snippet (there could be a function that chooses based on config.devenv.flakesIntegration which format to pick)
• make sure it doesn't break backwards compatibility

[domenkozar]

This should be done on top of #745

[domenkozar]

Closing as it's completely out of date, if someone wants to pick it up, please do.