Remove www. if present from setCookieDomain of JS tracking code #1
Conversation
… string is deprecated (matomo-org#21413) Co-authored-by: Stefan Giehl <stefan@matomo.org>
…omo-org#21926) * [Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.* * Apply coding style around FunctionCallSignature #1 (matomo-org#21927) * Apply coding style around FunctionCallSignature #2 (matomo-org#21928) * Apply coding style around FunctionCallSignature #3 (matomo-org#21929) * Apply coding style around FunctionCallSignature #4 (matomo-org#21930) * Apply coding style around FunctionCallSignature #5 (matomo-org#21931) * Apply coding style around FunctionCallSignature matomo-org#6 (matomo-org#21932) * Apply coding style around FunctionCallSignature matomo-org#7 (matomo-org#21933) * Apply coding style around FunctionCallSignature matomo-org#8 (matomo-org#21934) * Apply coding style around FunctionCallSignature matomo-org#9 (matomo-org#21935)
…#22991) * Avoid strlen(null) call on undefined "idvisitor" property The "idvisitor" property can be undefined/null, this must be taken into account to avoid this error: > strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /.../core/Tracker/Visit.php on line 583 * Use consistent check for undefined "idvisitor" property This is more in line with other locations in this class. Co-authored-by: Michal Kleiner <mk@011.nz> --------- Co-authored-by: Michal Kleiner <mk@011.nz>
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
|
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
When the first host has a
wwwsub domain this strips it out when generating thesetCookieDomainfor the JS tracking code.Also a very small bit of house keeping 🧹 .
If I had more time for this the next steps would be:
TrackerCodeGenerator.phpand extract all the complexity into smaller classes, with names with intent so it's a lot easier to follow._paq.push), using value objects in PHP and then creating a DTO or a view to convert into the javascript format required.