Merged
Conversation
Some method signatures were not updated. Also, some signatures respected the type hint and others did not, some reported the default value of the arguments and others did not, so I made them all uniform. I deliberately ignored everything regarding the `transliterate()` method, because in addition to the signature (not updated), the descriptive part should be revised.
dereuromark
reviewed
Feb 10, 2025
Contributor
Author
|
Thanks guys. If anyone has time and can do it, there is the whole |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some method signatures were not updated.
Also, some signatures respected the type hint and others did not, some reported the default value of the arguments and others did not, so I made them all uniform. I deliberately ignored everything regarding the
transliterate()method, because in addition to the signature (not updated), the descriptive part should be revised.