Fix remaining method signature issues across documentation#8185
Merged
dereuromark merged 2 commits into5.xfrom Jan 28, 2026
Merged
Fix remaining method signature issues across documentation#8185dereuromark merged 2 commits into5.xfrom
dereuromark merged 2 commits into5.xfrom
Conversation
Updated method signatures to include proper type annotations: - app.md: className() parameter types - collections.md: ~33 methods with full type annotations - email.md: setAttachments(), setEmailPattern() types and return - inflector.md: All 10 methods already had types (verified) - number.md: setDefaultCurrency() static and nullable type - text.md: transliterate(), toList() types (verified) - time.md: setJsonEncodeFormat(), i18nFormat(), comparison methods - xml.md: build(), toArray() types (verified) Refs #7744
- Fix malformed markdown syntax in table-objects.md (buildRules) and counter-cache.md (updateCounterCache) causing rendering issues - Add missing type annotations to ORM methods (save, findOrCreate, updateAll, deleteAll, Entity methods, ConnectionManager, TypeFactory) - Add parameter types to Controller methods (set, addViewClasses, fetchTable, fetchModel) - Add types to Response and CorsBuilder methods in request-response.md - Add types to ConsoleOptionParser methods in option-parsers.md - Add types to Helper callback methods and PaginatorHelper methods
josbeir
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table-objects.md(buildRules) andcounter-cache.md(updateCounterCache) that was causing rendering issuessave,findOrCreate,updateAll,deleteAll, Entity methods,ConnectionManager,TypeFactory)set,addViewClasses,fetchTable,fetchModel)ResponseandCorsBuildermethods inrequest-response.mdConsoleOptionParsermethods inoption-parsers.mdPaginatorHelpermethodsFiles Changed
docs/en/orm/table-objects.md- Fixed syntax error, added types tobeforeRules,afterRules,TableLocator::getdocs/en/orm/behaviors/counter-cache.md- Fixed syntax error inupdateCounterCachedocs/en/orm/database-basics.md- Added types toConnectionManager::get,DateTimeType::setTimezone,TypeFactory::mapdocs/en/orm/deleting-data.md- Added types toTable::deleteAlldocs/en/orm/entities.md- Added types toEntity::set,get,patchdocs/en/orm/saving-data.md- Added types toTable::save,findOrCreate,updateAlldocs/en/controllers.md- Added types toController::set,addViewClasses,fetchTable,fetchModeldocs/en/controllers/request-response.md- Added types toResponseandCorsBuildermethodsdocs/en/console-commands/option-parsers.md- Added types toConsoleOptionParsermethodsdocs/en/views/helpers.md- Added types to Helper callback methodsdocs/en/views/helpers/paginator.md- Added types toPaginatorHelper::sortDir,sortKeyCritical Fixes
Two syntax errors were causing malformed markdown rendering:
table-objects.md:276:buildRules**()**(RulesChecker→buildRules**(RulesCheckercounter-cache.md:171:updateCounterCache**()with extra**()at end