Fix code quality issues in documentation code snippets#8192
Merged
dereuromark merged 1 commit into5.xfrom Jan 29, 2026
Merged
Conversation
- Remove return statement from void method in database-basics.md - Add missing parameter and return type declarations to Point class, PointType, validation methods, entity accessors/mutators, and error handler methods - Add proper exception throw for unhandled case in toExpression() - Replace empty($id) with !$id for defined parameter in form.md
josbeir
reviewed
Jan 29, 2026
josbeir
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code quality issues found during a 5.x documentation audit:
returnfromvoidmethod indatabase-basics.md(initialize()hadreturn parent::getSchema()->...)Pointclass (__construct,parse,lat,long)PointTypeclass (toPHP,marshal,toExpression) — also renamed$dto$drivervalidationUpdate,validationCustomName,validatePasswords)_getTitle,_setTitle,_getFullName)missingWidgetin bothErrorControllerandAppExceptionRenderer)toExpression()(previously had only a// Handle other cases.comment with no code)empty($id)with!$idfor defined parameter inform.mdFiles changed:
database-basics.md,validation.md,entities.md,errors.md,form.md