-
Notifications
You must be signed in to change notification settings - Fork 11.5k
chore: Integrate reschedule request booking audit #26527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…value Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
…est-audit-1767769845
…est-audit-1767769845
…ld names and improve type definitions - Changed field names in the schema from `cancellationReason` and `cancelledBy` to `rescheduleReason` and `rescheduledRequestedBy`. - Updated the `getDisplayJson` method to reflect the new field names. - Added type imports for `ActionSource` in relevant files to enhance type safety. - Modified `requestRescheduleHandler` to accept and utilize the `source` parameter for audit logging.
| rescheduleReason: z.string().nullable(), | ||
| rescheduledRequestedBy: z.string().nullable(), | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old values aren't applicable here too as request rescheudle can happe only once for a booking
Also, rescheduled property isn't needed because we know it is a rescheudle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
E2E results are ready! |
…ompatibility Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Merge activity
|
What does this PR do?
Adds audit logging for the reschedule request flow. When an organizer requests an attendee to reschedule a booking, this action is now logged to the booking audit system.
This is part of the booking audit integration effort, following the pattern established in PR #26046 (booking creation/rescheduling audit) and PR #26458 (cancellation audit).
Changes
requestReschedule.handler.tsusingBookingEventHandlerService.onRescheduleRequested()rescheduleReason: The reason provided for requesting the reschedule (nullable string)rescheduledRequestedBy: Email of the user who requested the reschedulemakeUserActor(user.uuid)to identify the actor performing the actionsourceparameter for action source tracking (passed as"WEBAPP"from tRPC router)RescheduleRequestedAuditActionServiceschema to use simpler field structuregetTrpcHandlerDatato passsource: "WEBAPP"parameterUpdates since last revision
sourceparameter from optional with default to required - tests now explicitly passsource: "WEBAPP"instead of relying on a default valueMandatory Tasks (DO NOT REMOVE)
How should this be tested?
The audit logging follows the same pattern as other booking audit integrations, so if those are working, this should work as well.
Checklist
Link to Devin run: https://app.devin.ai/sessions/ae84d093c4594a5d89b88c45639a6a06
Requested by: @hariombalhara
Human Review Checklist
RescheduleRequestedAuditActionServiceexpectations (fields:rescheduleReason,rescheduledRequestedBy){ old, new }) to simple nullable strings is intentionaluser.uuidis available in the tRPC session context