-
Notifications
You must be signed in to change notification settings - Fork 34
feat(workflow): add late join test workflow with 3000 inserts and verification #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… adjust verification steps accordingly
… adjust verification steps accordingly
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
| /// Even if a caller requests more, the DAG will cap the result at this size. | ||
| /// The value selected as ~96 KB. | ||
| pub const MAX_DELTA_QUERY_LIMIT: usize = 3000; | ||
| pub const MAX_DELTA_QUERY_LIMIT: usize = 1_000_000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excessive limit increase removes OOM protection
High Severity
MAX_DELTA_QUERY_LIMIT and MAX_DELTA_FETCH_LIMIT increased from 3000 to 1,000,000 (333x) when the test only needs ~5000. The original limits were explicitly designed to "prevent resource exhaustion" and "prevent OOM where a peer sends a delta with a deep chain." This dramatic increase removes important memory safety guardrails that protect against malicious or corrupted peers causing out-of-memory conditions during sync operations.
Additional Locations (1)
SDK JS Workflows FailedThe following SDK JS workflow(s) failed:
Please check the workflow logs for more details. |
Merobox Workflows FailedThe following workflow(s) failed after retries:
Please check the workflow logs for more details. |
[Core] Add late-join test workflow for KV store
Description
Adds a workflow that tests late-join sync: Node 1 performs 3000 inserts, then Node 2 joins and verifies all entries are synced and accessible.
The workflow (
apps/kv-store/workflows/late-join-test.yml) covers:This tests the sync protocol's ability to catch up a late-joining node with a large state history.
On local testing it took around 30 sec for the context hash to match for both nodes.
Test plan
Documentation update
No documentation changes required .
Note
Strengthens late-join sync coverage and scalability.
apps/kv-store/workflows/late-join-test.ymlto simulate 5000 pre-join inserts on Node 1, then Node 2 joins and verifies state vialen,entries, and specificgetchecks (with a 100s wait)MAX_DELTA_QUERY_LIMITincrates/dag/src/lib.rsandMAX_DELTA_FETCH_LIMITincrates/node/src/sync/delta_request.rsfrom3000to1_000_000to support large history syncsWritten by Cursor Bugbot for commit d1b8022. This will update automatically on new commits. Configure here.