refactor: package overhaul #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
force-pushed
the
feat/package-overhaul
branch
2 times, most recently
from
58c04c3 to
467e679
Compare
okwasniewski
force-pushed
the
feat/package-overhaul
branch
from
467e679 to
d9b08ac
Compare
satya164
reviewed
Oct 6, 2025
| @@ -0,0 +1,42 @@ | |||
| # EXAMPLE USAGE: | |||
Member
There was a problem hiding this comment.
Mistake? This is a sample lefthook config and not actual config
| @@ -0,0 +1,71 @@ | |||
| import { type ReactNode, useEffect, useRef, useState } from 'react'; | |||
Member
There was a problem hiding this comment.
I prefer .native.tsx and .tsx instead because .web isn't supported in all bundlers and needs additional config.
| "peerDependencies": { | ||
| "react": ">=16", | ||
| "react-native": ">=0.57" | ||
| "modern-screenshot": "*", |
Member
There was a problem hiding this comment.
Is there a reason it can't be a regular dep?
| - name: Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0 | ||
| with: | ||
| node-version-file: .nvmrc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces a big package overhaul.
First of all there is no more JavaScript, everything is migrated to TypeScript, build scripts are using
react-native-builder-bob. The example is now using latest version of React Native.Test Plan
This is only bumping example and changing the build process. Improvements like new architecture support are coming in next PRs