- 
                Notifications
    You must be signed in to change notification settings 
- Fork 276
feat: event debugging (WIP) #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
- Coverage   95.50%   95.47%   -0.04%     
==========================================
  Files          92       92              
  Lines        5139     5235      +96     
  Branches      563      901     +338     
==========================================
+ Hits         4908     4998      +90     
- Misses        231      237       +6     ☔ View full report in Codecov by Sentry. | 
ec51869    to
    81a631b      
    Compare
  
    81a631b    to
    ec9b076      
    Compare
  
    | Could you share your feedback on this potential new feature @pierrezimmermannbam @MattAgn @AugustinLF | 
| concurrentRoot: boolean; | ||
|  | ||
| /** | ||
| * Verbose logging for the library. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would add what it helps log : user event and fire event issues (for now)
| asyncUtilTimeout: 1000, | ||
| defaultIncludeHiddenElements: false, | ||
| concurrentRoot: true, | ||
| debug: false, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo true is a good default because otherwise i fear not many people will hear about it and remember to turn it on
do you see more advantages with false as default ?
| This is gonna be so helpful to debug! ✅ | 
95845da    to
    fc93a55      
    Compare
  
    
Summary
Resolves #1717
Resolves #1718
Introduces (event) debugging mode that outputs information about event handles not being called due to disabled state, etc.
Details
Enabling:
configure({ debug: true }). Cannot be configured onrenderasfireEventanduserEventare independent modules, not returns fromrender.Fire Event:
fireEventcall.User Event:
To Do
userEventcall.Test plan