-
Notifications
You must be signed in to change notification settings - Fork 37
Add gherkin linting & fix issues in *.feature-files #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gherkin linting & fix issues in *.feature-files #329
Conversation
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jlurien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would separate the PRs. Leave this one just to fix issue #328, with changes related to linting management.
Then create a separate one to fix the specs and test plans. Specially, geofencing-subcriptions.feature introduces a lot of changes not related with the issue
I agree, the problem is that when I'll activate it, the Megalinter will fail. |
bcfbd54 to
fdbb46c
Compare
|
The fixes for Megalinter will come by merging #331 first. |
jlurien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing with the Commonalities sources
jlurien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxl2287 CI failed
jlurien
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Adds
gherkin-linting, restructure and fixes *.feature-filesWhich issue(s) this PR fixes:
Fixes #328