Skip to content

Conversation

@maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented May 15, 2025

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Adds gherkin-linting, restructure and fixes *.feature-files

Which issue(s) this PR fixes:

Fixes #328

@maxl2287 maxl2287 self-assigned this May 15, 2025
@maxl2287 maxl2287 added enhancement New feature or request correction Fall25 Meta-release Fall25 labels May 15, 2025
@maxl2287 maxl2287 changed the title feat: add gherkin linting feat: add gherkin linting & fix issues in *.feature-files May 15, 2025
@maxl2287 maxl2287 marked this pull request as ready for review May 15, 2025 21:45
@maxl2287 maxl2287 requested review from bigludo7 and jlurien as code owners May 15, 2025 21:45
@maxl2287 maxl2287 changed the title feat: add gherkin linting & fix issues in *.feature-files Add gherkin linting & fix issues in *.feature-files May 15, 2025
bigludo7
bigludo7 previously approved these changes May 16, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxl2287 maxl2287 added the tests Improvements or additions to test-definitions label May 19, 2025
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would separate the PRs. Leave this one just to fix issue #328, with changes related to linting management.
Then create a separate one to fix the specs and test plans. Specially, geofencing-subcriptions.feature introduces a lot of changes not related with the issue

@maxl2287
Copy link
Contributor Author

I would separate the PRs. Leave this one just to fix issue #328, with changes related to linting management. Then create a separate one to fix the specs and test plans. Specially, geofencing-subcriptions.feature introduces a lot of changes not related with the issue

I agree, the problem is that when I'll activate it, the Megalinter will fail.
So maybe I need then to merge the upcoming fix of testing-issues PR first and then the gherkin-linting after.

@maxl2287
Copy link
Contributor Author

The fixes for Megalinter will come by merging #331 first.

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing with the Commonalities sources

@jlurien
Copy link
Collaborator

jlurien commented Jun 3, 2025

The fixes for Megalinter will come by merging #331 first.

#331 is more complex than just linting fixes. We may merge this one independently and the linter will complain eventually about what's wrong in the other

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxl2287 CI failed

@maxl2287
Copy link
Contributor Author

maxl2287 commented Aug 7, 2025

@jlurien / @bigludo7 please take a look :)

@maxl2287 maxl2287 requested review from bigludo7 and jlurien August 7, 2025 07:16
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien
Copy link
Collaborator

jlurien commented Aug 13, 2025

@maxl2287 You can wait for @bigludo7, but it should be OK to merge it now

@maxl2287 maxl2287 merged commit ad6fcbe into camaraproject:main Aug 13, 2025
2 checks passed
@maxl2287 maxl2287 deleted the feature/add-gherkin-linting branch August 13, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Fall25 Meta-release Fall25 tests Improvements or additions to test-definitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add gherkin-linting for *.feature-files based on Commonalities

3 participants