Conversation
documentation/API_documentation/qos-booking-and-assignment-API-Readiness-Checklist.md
Show resolved
Hide resolved
Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
jlurien
left a comment
There was a problem hiding this comment.
LGTM, please sync with latest commits in master
+1 ... the two open PRs look ready to be merged into main, and then update the release PR from main. |
|
The two PRs have been merged. And this release PR has been updated. |
|
@jlurien, for my clarification, have you approved this PR as Release Managemetn team, not as code owner? If yes, I will merge this PR. |
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
|
@Kevsy , Thank you for your comments. I have updated based on your comments. Please review it again. |
There was a problem hiding this comment.
Approved on behalf of Release Management 👏
Next steps for the team:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
@Masa8106 Jose is on vacation and will not be back on time if I understood it right. I have reviewed the changes since his review and haven't found anything critical. The changes in .feature files aligned them with what we have in QualityOnDemand. Given that I can offer to bypass the rules as admin and merge the PR for you. Just let me know if that is ok for you. |
|
@hdamker Thank you for letting me know that. I will be happy if we can bypass the rule, in order to release this in time. |
hdamker
left a comment
There was a problem hiding this comment.
LGTM and will merge it now.
|
HI @Masa8106 , you can now proceed with the final tasks:
|
|
Hi @Kevsy , thank you for reminding me the final tasks. I have done them. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #46
Special notes for reviewers: