Skip to content

Release r1.2 (M4 Fall25)#51

Merged
hdamker merged 29 commits intocamaraproject:mainfrom
Masa8106:Masa8106-release-r1.2
Sep 12, 2025
Merged

Release r1.2 (M4 Fall25)#51
hdamker merged 29 commits intocamaraproject:mainfrom
Masa8106:Masa8106-release-r1.2

Conversation

@Masa8106
Copy link
Contributor

What type of PR is this?

  • subproject management

What this PR does / why we need it:

  • Set API versions
    • qos-booking v0.1.0
    • qos-booking-and-assignment v0.1.0
  • Update test definitions
  • Update changelog
  • Update readme
  • Update readiness checklist files

Which issue(s) this PR fixes:

Fixes #46

Special notes for reviewers:

@Masa8106 Masa8106 requested review from a team and jlurien as code owners August 29, 2025 23:04
@Masa8106 Masa8106 changed the title Release r3.2 (M4 Fall25) Release r1.2 (M4 Fall25) Aug 29, 2025
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ... few suggestions below

Note: I haven't done the official release review, just pre-reviewed as member of QualityOnDemand

@hdamker hdamker requested a review from a team August 30, 2025 15:21
@Masa8106
Copy link
Contributor Author

Masa8106 commented Sep 1, 2025

@hdamker, two new PRs (PR #54 and PR #55 ) were created after creating this release PR. The PRs propose just to fix bugs. So let me confirm whether we can merge the two PRs into main as r1.2 release. If possible, I would like to do that.

@hdamker
Copy link
Contributor

hdamker commented Sep 1, 2025

@hdamker, two new PRs (PR #54 and PR #55 ) were created after creating this release PR. The PRs propose just to fix bugs. So let me confirm whether we can merge the two PRs into main as r1.2 release. If possible, I would like to do that.

Yes, that is my expectation: to take these fixes into r1.2.

jlurien
jlurien previously approved these changes Sep 3, 2025
Copy link
Contributor

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please sync with latest commits in master

@hdamker
Copy link
Contributor

hdamker commented Sep 3, 2025

LGTM, please sync with latest commits in master

+1 ... the two open PRs look ready to be merged into main, and then update the release PR from main.

@Masa8106
Copy link
Contributor Author

Masa8106 commented Sep 3, 2025

The two PRs have been merged. And this release PR has been updated.
So I think this PR is ready to bereviewed by release manegement. I will wait for an approval by it.

@Masa8106
Copy link
Contributor Author

Masa8106 commented Sep 3, 2025

@jlurien, for my clarification, have you approved this PR as Release Managemetn team, not as code owner? If yes, I will merge this PR.

Masa8106 and others added 11 commits September 11, 2025 12:38
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
@Masa8106
Copy link
Contributor Author

@Kevsy , Thank you for your comments. I have updated based on your comments. Please review it again.

Copy link
Contributor

@Kevsy Kevsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of Release Management 👏

Next steps for the team:

  • PR merged (by API repository codeowner)
  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@Masa8106
Copy link
Contributor Author

@Kevsy , thank you so much for reviewing it.
@jlurien , may I ask you to review it again? Another code owner review is required for merge.

@hdamker
Copy link
Contributor

hdamker commented Sep 11, 2025

@jlurien , may I ask you to review it again? Another code owner review is required for merge.

@Masa8106 Jose is on vacation and will not be back on time if I understood it right. I have reviewed the changes since his review and haven't found anything critical. The changes in .feature files aligned them with what we have in QualityOnDemand. Given that I can offer to bypass the rules as admin and merge the PR for you. Just let me know if that is ok for you.

@Masa8106
Copy link
Contributor Author

@hdamker Thank you for letting me know that. I will be happy if we can bypass the rule, in order to release this in time.

Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and will merge it now.

@hdamker hdamker merged commit 0aeba3f into camaraproject:main Sep 12, 2025
2 checks passed
@Kevsy
Copy link
Contributor

Kevsy commented Sep 12, 2025

HI @Masa8106 , you can now proceed with the final tasks:

  • Release created within GitHub (by API repository codeowner)
  • Release Tracker updated (with creation date of the release and the release tag link)

@Masa8106
Copy link
Contributor Author

Hi @Kevsy , thank you for reminding me the final tasks. I have done them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the release r1.2 as the public release for Fall25

4 participants