Conversation
1. Address Issue camaraproject#64 2. Clean-up description in for some end points.
|
@hdamker and others: I have added 202 status code to handle async pending events. But I have noticed that I have one 'callbacks:' section in booking and one in assignement of devices. Do I have to have separate 'callbacks' for every operation that is async? I have reviewed commonalities but could not locate anything relevant. OpenAPI 3.0 spec seems to mandate this. Any input? |
@RamTMO I can remember that I had this question already before the 0.1.0 version and you had some argument(s) why it make sense for you to have two different callback targets. But I can't find it easily. |
@hdamker That is correct. It was considered to scale these APIs to support if booking is done by party-1 and assignements are done by party-2; so we addressed this with two different callbacks. But my question was different. More related to .yaml syntax and/or commonality requirements. I could not find one. In booking alone I have 'booking' as well as 'delete booking' as async end points. In 'booking' endpoint I have 'callbacks' section and but not in 'delete booking'. Is it okay? or do I have to duplicate the 'callbacks' code in 'delete booking' also. We can discuss this in our next meeing. |
Removed trailing spaces
Second set of lint fixes
|
@Masa8106 Are you able to review this and other PRs? Appriciate it |
|
@RamTMO , I have confirmed that all linting error was resolved. |
|
@Masa8106 Yes, that is correct. I just cleaned-up the success codes in this PR; especailly 202 will be returned when the status is PENDING for async operations. In addition, I have updated some comments. Following is from the issue:
|
|
In my opinion, as the QoS B&A API is applicable for multi-device handling, I think there is need for async operation more. |
What type of PR is this?
What this PR does / why we need it:
This PR fixes #64. It address the correct success return code (202 when needed) for all end points.
Which issue(s) this PR fixes:
Fixes #64
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.