Create threaded_furkan_bulut.py #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canbula
requested changes
Dec 25, 2024
Owner
canbula
left a comment
canbula
left a comment
There was a problem hiding this comment.
Solve this with 2 functions, 3 wrapped functions are redundant.
Furk4nBulut
commented
Dec 25, 2024
Contributor
Author
Furk4nBulut
left a comment
Furk4nBulut
left a comment
There was a problem hiding this comment.
Describe your changes
Checklist
- I have read the [CONTRIBUTING]
- I have performed a self-review of my own code
- I have run the code locally and it works as expected
- I have commented my code, particularly in hard-to-understand areas
canbula
requested changes
Dec 26, 2024
Owner
canbula
left a comment
canbula
left a comment
There was a problem hiding this comment.
Reduce the number of inner functions.
Furk4nBulut
commented
Dec 26, 2024
Contributor
Author
Furk4nBulut
left a comment
Furk4nBulut
left a comment
There was a problem hiding this comment.
Describe your changes
Checklist
- I have read the [CONTRIBUTING]
- I have performed a self-review of my own code
- I have run the code locally and it works as expected
- I have commented my code, particularly in hard-to-understand areas
Furk4nBulut
commented
Dec 28, 2024
Contributor
Author
Furk4nBulut
left a comment
Furk4nBulut
left a comment
There was a problem hiding this comment.
Describe your changes
Refactored the code to a class-based implementation.
Checklist
- I have read the [CONTRIBUTING]
- I have performed a self-review of my own code
- I have run the code locally and it works as expected
- I have commented my code, particularly in hard-to-understand areas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist