-
Notifications
You must be signed in to change notification settings - Fork 117
ci: configure TICS workflow #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| on: pull_request | ||
| # on: | ||
| # schedule: | ||
| # - cron: "0 22 * * 5" | ||
| # workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For QA. Remove pull_request and uncomment before merging
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2117 +/- ##
=======================================
Coverage 77.20% 77.20%
=======================================
Files 16 16
Lines 1676 1676
=======================================
Hits 1294 1294
Misses 382 382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
509e8fb to
6fe1d6a
Compare
afcc9de to
11b205a
Compare
db6cce3 to
93cde03
Compare
93cde03 to
da03886
Compare
immortalcodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. The dashboard looks good, I have mostly exploratory comments.
| coverage run --data-file=.coverage_db --source=webapp -m unittest discover tests && | ||
| coverage report --data-file=.coverage_db && | ||
| coverage xml --data-file=.coverage_db -o coverage/coverage.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help me understand this commands better, as far as I know the coverage is already calculated in other test workflows, what's different here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commands run coverage on python code locally, and generate coverage outpul in xml format.
The coverage calculated in other workflows is on the PR itself. The reason for doing it here is on the main branch of repo, which is going to run every week.
.github/workflows/tiobe_config.txt
Outdated
| @@ -0,0 +1,12 @@ | |||
| 'DIR' => | |||
| "/webapp/" || | |||
| "/templates/" || | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not expected, it should be included.
I have updated the tiobe config, so it should now be generated.
69eafac to
3f19661
Compare
8eee1f5 to
8c7e707
Compare
2155792 to
8f1c01b
Compare

Note: uncomment PR action trigger before merging
Done
tiobe_config.txttics_coverage.yamlbuild-coverage. The coverage report is then uploaded as an artifactTICSaction downloads the GH artifact and publishes it on TICS ViewerQA
TICS Analysis and coverageaction passes, specificallyTICS (22.x)Issue / Card
Fixes WD-30653 and WD-30654
Screenshots