Skip to content

Remove all glmark2 symlink hacks (Bugfix)#2287

Closed
tomli380576 wants to merge 16 commits intomainfrom
remove-symlink-hacks
Closed

Remove all glmark2 symlink hacks (Bugfix)#2287
tomli380576 wants to merge 16 commits intomainfrom
remove-symlink-hacks

Conversation

@tomli380576
Copy link
Contributor

@tomli380576 tomli380576 commented Jan 15, 2026

Description

This is the followup PR for #2281 that removes all symlink hacks.

Resolved issues

  1. Remove all symlink hacks
  2. CHECKBOX_RUNTIME has multiple lines. Added a function that explicitly searches for $SNAP/checkbox-runtime

Documentation

Tests

C3 submissions:

  • classic desktop
  • ubuntu frame

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.46%. Comparing base (f8136c5) to head (7da289e).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
providers/base/bin/reboot_check_test.py 50.00% 4 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (61.53%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2287      +/-   ##
==========================================
- Coverage   54.49%   54.46%   -0.04%     
==========================================
  Files         409      409              
  Lines       43970    43954      -16     
  Branches     8100     8096       -4     
==========================================
- Hits        23961    23938      -23     
- Misses      19190    19197       +7     
  Partials      819      819              
Flag Coverage Δ
provider-base 31.30% <61.53%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomli380576
Copy link
Contributor Author

Closing this since it contains workarounds for #2295

@tomli380576 tomli380576 closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant