Fix eddystone scanner for controllers without extended advertising support (Bugfix)#2293
Closed
Copilot wants to merge 1 commit intorevise_eddystone_scannerfrom
Closed
Fix eddystone scanner for controllers without extended advertising support (Bugfix)#2293Copilot wants to merge 1 commit intorevise_eddystone_scannerfrom
Copilot wants to merge 1 commit intorevise_eddystone_scannerfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix bugged behaviour of eddystone scanner
Fix eddystone scanner for controllers without extended advertising support (Bugfix)
Jan 16, 2026
Collaborator
|
Thanks no thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The eddystone scanner failed on Bluetooth 5.0 controllers lacking extended advertising support. The scanner assumed all BT 5.0+ controllers support extended advertising, causing failures when attempting to use extended scan commands.
Changes made:
The scanner now successfully detects Eddystone beacons on controllers with
Extended advertising support: False, as verified on RPi4 with Cypress BT 5.0 controller (HCI v5.0).Resolved issues
Documentation
Tests
Verified on RPi4 with Bluetooth 5.0 controller (Cypress Semiconductor, HCI v5.0):
Scanner successfully:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.