Exclude SRU disk stress tests from server-disk test plan (bugfix)#2330
Merged
Exclude SRU disk stress tests from server-disk test plan (bugfix)#2330
Conversation
The regex disk/disk_stress_ng_.* was matching both the full disk stress
tests and the SRU variants. Use a negative lookahead to exclude the SRU
tests, so only disk_stress_ng_{name} is selected when running a full
certificaiton test run
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
=======================================
Coverage 55.30% 55.30%
=======================================
Files 413 413
Lines 44505 44505
Branches 8205 8205
=======================================
Hits 24613 24613
Misses 19031 19031
Partials 861 861
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mreed8855
changed the title
mreed8855
changed the title
mreed8855
changed the title
Collaborator
|
LGTM. I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude SRU disk stress tests from server-disk test plan. This fixes PR #2185
Description
When I added an abbreviated disk test for SRU testing I accidentally introduced the sru test in the main certification run when running certify-ubuntu-server and certify-22.04. This fix will eliminate that.
The regex disk/disk_stress_ng_.* was matching both the full disk stress tests and the SRU variants. Use a negative look ahead to exclude the SRU tests, so only disk_stress_ng_{name} is selected when running a full certification test run
Resolved issues
This resolves issue #2185
Documentation
No documentation changes are required.
Tests
Run certify certify-ubuntu-server or certify-22.04 and verify the disk disk_stress_ng_sru_* are not in the available tests