-
Notifications
You must be signed in to change notification settings - Fork 19
docs: add a preview page for reusing packages #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds a preview page for how to reuse packages between builds. Also prepares for the 5.11.0 release. Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
| with the appropriate changes | ||
|
|
||
| .. literalinclude:: reuse-packages-between-builds.rst | ||
| :start-after: .. :docs-include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no blank line here because otherwise the blank line would be included in the self-referential literalinclude.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't in line with what we want from a page of documentation.
I left it out of Craft Application because I didn't think the generic page would be of use to Craft Application readers. Do you want to include it instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would definitely like it to be available in the docs so people can see what would look like in their app's docs (and make it more discoverable for app docs).
|
Marking as draft so we can discuss proper solutions here. |
Adds a preview page for how to reuse packages between builds.
Also prepares for the 5.11.0 release.
make lint && make test?docs/reference/changelog.rst)?