Skip to content

Conversation

@lengau
Copy link
Contributor

@lengau lengau commented Apr 25, 2025

This switches from the pyright pip package to the pyright snap.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

This switches from the pyright pip package to the pyright snap.

Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
@lengau lengau force-pushed the work/update-pyright branch from c1fd37a to 5f3abce Compare October 1, 2025 20:44
@lengau lengau requested a review from tigarmo as a code owner October 1, 2025 20:44
@lengau lengau requested a review from bepri October 1, 2025 20:44
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
Copy link
Member

@steinbro steinbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff only shows the pip package being removed.

@lengau
Copy link
Contributor Author

lengau commented Dec 15, 2025

@steinbro yeah the rest of it happens through the pre-existing setup stuff in the common.mk, where if pyright isn't already installed it'll install the snap.

@lengau lengau merged commit 21d7e62 into main Dec 15, 2025
20 checks passed
@lengau lengau deleted the work/update-pyright branch December 15, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants