style(types): enable type checking with ty #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lengau
force-pushed
the
work/enable-ty
branch
from
f31c1b7 to
c4b4082
Compare
steinbro
approved these changes
Dec 17, 2025
bepri
approved these changes
Dec 17, 2025
Comment on lines
608
to
+609
| sys.exit() | ||
| assert func is not None # noqa: S101, type narrowing |
Member
There was a problem hiding this comment.
Looks like ty has an issue for this, could you put it in a comment so we can delete it once it's fixed? astral-sh/ty#690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint && make test?