Skip to content

Clear popups#270

Open
mariuskava wants to merge 6 commits intomainfrom
clear-popups
Open

Clear popups#270
mariuskava wants to merge 6 commits intomainfrom
clear-popups

Conversation

@mariuskava
Copy link
Contributor

Done

  • After each page navigation clear popups if they exist

@nathanclairmonte
Copy link
Contributor

LGTM! pending update on the tests which are failing, I suspect the tests are now out of date with this change

@nobuto-m
Copy link
Member

It doesn't work to resolve #268

[before - with b794735]

$ ts-node ./src/index.ts replicate -i
✔ Using the saved credentials.
✔ Setup is completed.
✔ Fetching your jobs.

...

✔ What region should those job posts be? Use space to make a selection. · apac
✔ Do you want to remove existing job posts? · No / Yes
⠙ 1 of 30 job posts are created.^C

-> stuck for minutes (up to 10 min I suppose due to #269)

[after - with 2781111]

$ ts-node ./src/index.ts replicate -i
✔ Using the saved credentials.
✔ Setup is completed.
✔ Fetching your jobs.

...

✔ What region should those job posts be? Use space to make a selection. · apac
✔ Do you want to remove existing job posts? · No / Yes
⠇ 1 of 30 job posts are created.

-> stuck in the same way.

I need to record the session to see what's going on.

@nobuto-m
Copy link
Member

⠇ 1 of 30 job posts are created.

-> stuck in the same way.

One correction. It's not in the same way actually. I got the following error instead.

⠹ 1 of 30 job posts are created.✖ Error replicating job post: ProtocolError: Page.navigate timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.

@nobuto-m
Copy link
Member

Recording: https://drive.google.com/file/d/1pL8oPZz-J8ZQl7fWpSyyQoNjraAeMIGT/view?usp=sharing

Looks like the pop-up is popping up twice(?).

@nobuto-m
Copy link
Member

With 67a438a, it fails. HOWEVER, I don't see the pop-up any longer in the recording so I guess we need to identify another root cause...

@nobuto-m
Copy link
Member

When I pass NODE_ENV=development to see the browser in action, I see the following state. During 1 of 30 job posts are created, the browser gives a warning about unsaved data and preventing the transition to the next page.

Screenshot From 2025-05-20 21-59-04

@nobuto-m
Copy link
Member

#268 (comment)

@nobuto-m
Copy link
Member

I think this is still nice to have even thought it may not be the root cause of a real issue. When debugging the session, the banner interferes with seeing what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants