Skip to content

Conversation

@AnneCYH
Copy link
Collaborator

@AnneCYH AnneCYH commented Mar 11, 2025

No description provided.

AnneCYH added 3 commits March 11, 2025 14:48
Signed-off-by: AnneCYH <anne.chew@canonical.com>
Signed-off-by: AnneCYH <anne.chew@canonical.com>
Signed-off-by: AnneCYH <anne.chew@canonical.com>
@github-actions
Copy link

AnneCYH added 2 commits March 11, 2025 14:55
Signed-off-by: AnneCYH <anne.chew@canonical.com>
Signed-off-by: AnneCYH <anne.chew@canonical.com>
@AnneCYH AnneCYH requested a review from benjamin051000 March 12, 2025 01:18
Copy link

@benjamin051000 benjamin051000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a more descriptive title. Everything else looks good.

@benjamin051000
Copy link

Any idea why CI is failing?

Co-authored-by: Benjamin Wheeler <34549440+benjamin051000@users.noreply.github.com>
Signed-off-by: AnneCYH <anne.chew@canonical.com>
@AnneCYH
Copy link
Collaborator Author

AnneCYH commented Mar 13, 2025

There was a breaking change in the starter pack due to addition of support for Launchpad repos for docs. So unless I rebase this on top of main it'll fail but I'll go ahead and merge it.

Thanks for the review @benjamin051000 !

@AnneCYH AnneCYH merged commit 0e331af into main Mar 13, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants