Skip to content

Conversation

@SaiRajeshRamaraju
Copy link

Summary

Removed the localnode.yaml copy step from scripts/inspect.sh for dqlite, because recent dqlite versions no longer create localnode.yaml and instead use cluster.yaml and info.

References:

#5359

Changes

Removed the cp ${SNAP_DATA}/var/kubernetes/backend/localnode.yaml line from the dqlite inspection section in scripts/inspect.sh.

The inspection now only collects cluster.yaml and info.yaml from the dqlite backend directory, which are the files produced by current dqlite.

Testing

Ran microk8s inspect on a node using the current MicroK8s/dqlite backend and verified:

    No cp: cannot stat '.../localnode.yaml' error is emitted.

The inspection report tarball still contains the dqlite directory with cluster.yaml, info.yaml, and the backend directory listing.

Possible Regressions

Older MicroK8s installations or dqlite layouts that still create and rely on localnode.yaml will no longer have that file included in inspection reports.

However, current supported MicroK8s versions use cluster.yaml and info.yaml as the authoritative dqlite state, so impact is expected to be minimal.

Checklist

[* ] Read the contributions page.
[ *] Submitted the CLA form, if you are a first time contributor.
[ *] The introduced changes are covered by unit and/or integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant