Update ovsdb relation to handle multiple relations#64
Open
crypticC0der wants to merge 2 commits intocanonical:mainfrom
Open
Update ovsdb relation to handle multiple relations#64crypticC0der wants to merge 2 commits intocanonical:mainfrom
crypticC0der wants to merge 2 commits intocanonical:mainfrom
Conversation
Allows ovsdb to support being used by multiple charms, also updates the relation data once a unit has joined the cluster to avoid desync. Fixes: lp-2138439 Fixes: lp-2138426 Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
crypticC0der
force-pushed
the
betterovsdb
branch
from
039a501 to
3355d41
Compare
gboutry
reviewed
Mar 18, 2026
| return | ||
| self.unit.status = ops.MaintenanceStatus("Refreshing MicroOVN snap") | ||
| self.microovn_snap_client.install() | ||
| self._on_update_status(event) |
Contributor
There was a problem hiding this comment.
There is CollectStatusEvent
That can run per unit and per leader unit (unit vs app) at every hook (it's an OPS only lifecycle event) if you don't want not to have not to forger to put it everywhere.
Currently if the user is enabling and disabling services through the microovn snap service control capabilities the ovsdb relation can get out of date. We would like to make this an invalid use case through a possible role-distributor but for now we need to support it and the easiest way to do this is just updating the relation as part of the update status hook. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
Collaborator
Author
|
flaky tests due to: #63 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows ovsdb to support being used by multiple charms, also updates the relation data once a unit has joined the cluster to avoid desync.
Fixes: lp-2138439
Fixes: lp-2138426