test: verify central IPs are set even when central is already disabled#67
Open
matperin wants to merge 1 commit intocanonical:mainfrom
Open
test: verify central IPs are set even when central is already disabled#67matperin wants to merge 1 commit intocanonical:mainfrom
matperin wants to merge 1 commit intocanonical:mainfrom
Conversation
Add assert_any_call checks for both the 'disable central' and 'config set ovn.central-ips' calls in test_dataplane_mode_disable_central_fails_already_disabled. The test previously only asserted the return value, leaving the regression fixed in 31ff7e2 uncovered. The new assertions ensure both commands are always called in this path. Signed-off-by: Matteo Perin <matteo.perin@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add assert_any_call checks for both the 'disable central' and 'config set ovn.central-ips' calls in
test_dataplane_mode_disable_central_fails_already_disabled.
The test previously only asserted the return value, leaving the regression fixed in 31ff7e2 uncovered.
The new assertions ensure both commands are always called in this path.