Add OVS database migration capabilities.#68
Conversation
crypticC0der
force-pushed
the
migrateovs
branch
2 times, most recently
from
14d41ee to
37af0e2
Compare
fnordahl
left a comment
fnordahl
left a comment
There was a problem hiding this comment.
Thank you for your work on this.
I'd prefer if the charm would do the required steps prior to install, this would simplify the solution and also contain the feature in the charm, requiring no further changes to the snap.
I have a couple suggestions in-line on how we could test this without having to bend the implementation for test purposes.
|
my concern with taking down OVS before microovn install is that if OVS is handling networking in such a way that taking it down means loosing external internet access, we would then be unable to install microovn (due to the lack of internet access now OVS is down) |
ha, that is indeed a very good concern, perhaps even a better reason to put in that comment as I read it to be done this way mainly because of being hard to test as opposed to this chicken and egg problem. |
crypticC0der
force-pushed
the
migrateovs
branch
from
0a78971 to
bef6083
Compare
|
new token distributor library canonical/microcluster-token-distributor-operator#14 |
fnordahl
dismissed
their stale review
Dropping my request for changes on the back of discussion and to avoid deterring other reviewers if they get to look at the next iteration sooner than me
|
K8s test fixed 👁️ 👁️ |
crypticC0der
force-pushed
the
migrateovs
branch
from
562fe85 to
a57f4b8
Compare
If the openvswitch-switch service is running and theres a conf.db file where its expected to be: shutdown that version of OVS, and take its database which we then use as the starting point for the microovn switch database. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
There has been an update by a very talented developer at the token distributor charm, she has added prejoin and prebootstrap hooks, which give us functionality to make our implementation of OVS DB migration slightly cleaner. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
Switch to k8s over microk8s for stability. Rework k8s integration test to have smaller steps and fewer units to conserve resources. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
Flags microovn to bypass the OVS checks and allow the user to install microovn anyway. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
crypticC0der
force-pushed
the
migrateovs
branch
from
a57f4b8 to
ca14fe5
Compare
2 participants
If the openvswitch-switch service is running and theres a conf.db file where its expected to be: shutdown that version of OVS, and take its database which we then use as the starting point for the microovn switch database.