Skip to content

[fix] Add robustness to peer address resolution#209

Open
paulomach wants to merge 6 commits into8.0/edgefrom
fix/fqdn-dns-for-good
Open

[fix] Add robustness to peer address resolution#209
paulomach wants to merge 6 commits into8.0/edgefrom
fix/fqdn-dns-for-good

Conversation

@paulomach
Copy link
Copy Markdown
Contributor

@paulomach paulomach commented Apr 4, 2026

Fix #137

  • Leverage name resolution order (/etc/hosts/ -> dns) to solve self and peer fqdn.
  • For peer resolution, skip dns, by using self fqdn and replacing pod name part.
  • DNS is kept as fallback.

@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Apr 4, 2026
@paulomach paulomach added the bug Something isn't working as expected label Apr 4, 2026
@paulomach paulomach marked this pull request as ready for review April 7, 2026 11:42
Copy link
Copy Markdown
Contributor

@sinclert-canonical sinclert-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving it ASAP to leave the PR unblock.

Please, address the comments whenever possible.

Copy link
Copy Markdown
Contributor

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No extra comments from my side

@paulomach
Copy link
Copy Markdown
Contributor Author

Waiting for the K8s issues to be clarified before merging.

@sinclert-canonical
Copy link
Copy Markdown
Contributor

Judging by this issue in the K8s-snap repo, are these changes still necessary?

@paulomach
Copy link
Copy Markdown
Contributor Author

Judging by this issue in the K8s-snap repo, are these changes still necessary?

Not strictly, but I would like to keep it as it enables less reliance on DNS. Thoughts?

@sinclert-canonical
Copy link
Copy Markdown
Contributor

Not strictly, but I would like to keep it as it enables less reliance on DNS. Thoughts?

I think the FQDN resolution using /etc/hosts can stay, if you think this is applicable to all K8s environments. However, the automatic retries should be pruned until we are made aware that the current logic is time-sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants