Refactor: improve error message and readability#16
Closed
romavicdosanjos wants to merge 2 commits intocanonical:mainfrom
Closed
Refactor: improve error message and readability#16romavicdosanjos wants to merge 2 commits intocanonical:mainfrom
romavicdosanjos wants to merge 2 commits intocanonical:mainfrom
Conversation
The error message for network connectivity issues is now more user-friendly. Code readability has been improved by adjusting line breaks for long lines.
Collaborator
fernando79513
left a comment
fernando79513
left a comment
There was a problem hiding this comment.
TYVM for the contribution, I've just left a small comment.
Comment on lines
82
to
86
| return Center( | ||
| child: Text( | ||
| 'An error occurred while trying to connect to the server.\nPlease check your connection or try again later.', | ||
| textAlign: TextAlign.center, | ||
| )); |
Collaborator
There was a problem hiding this comment.
Since the PR is mainly for improving readability, please also split this line:
Suggested change
| return Center( | |
| child: Text( | |
| 'An error occurred while trying to connect to the server.\nPlease check your connection or try again later.', | |
| textAlign: TextAlign.center, | |
| )); | |
| child: Text( | |
| 'An error occurred while trying to connect to the server.' | |
| '\nPlease check your connection or try again later.', | |
| textAlign: TextAlign.center, | |
| )); |
Author
There was a problem hiding this comment.
@fernando79513 You are right, the improvement was done.
Author
There was a problem hiding this comment.
Hi @fernando79513, I'm closing this PR because all the changes here have been incorporated into this one: #19. Thanks!
The error message for server connection issues in `lib/comic.dart` has been reformatted for better readability by ensuring the newline character correctly separates the sentences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error message for network connectivity issues is now more user-friendly.
Code readability has been improved by adjusting line breaks for long lines.