Skip to content

Conversation

@samhotep
Copy link
Member

@samhotep samhotep commented Dec 13, 2024

Done

  • Added rate limiting to the marketo endpoint

QA

  • Fill out a marketo form e.g https://ubuntu-com-14569.demos.haus/ai#get-in-touch, submit and re-submit before 4s have elapsed. The request should return a 429 error.
  • Wait for another 4s and make another request, This one should pass through.
  • Feel free to adjust the limits in this PR while testing.

Issue / Card

Fixes WD-15861

Help

QA steps - Commit guidelines

@webteam-app
Copy link

@petesfrench
Copy link
Contributor

QA result: I was able to hit the rate limit and throw a 429 once, but after that was unable to hit it again

@samhotep
Copy link
Member Author

@petesfrench I have made an update to fix this, could you please try again?

@petesfrench
Copy link
Contributor

QA results: This time I wasn't able to hit the rate limit at all

@samhotep
Copy link
Member Author

@petesfrench I've reworked it a bit, and added some optional params

@samhotep samhotep force-pushed the add-rate-limit-for-marketo branch 2 times, most recently from c59b6e0 to 39a0036 Compare January 10, 2025 08:51
@samhotep samhotep force-pushed the add-rate-limit-for-marketo branch from 39a0036 to a595d08 Compare January 15, 2025 13:37
@samhotep samhotep force-pushed the add-rate-limit-for-marketo branch from f5fc68b to 34955f0 Compare January 15, 2025 13:55
@petesfrench
Copy link
Contributor

@samhotep In all my attempts I have not been able to hit the rate limit

@Onibenjo
Copy link
Contributor

@samhotep
Is this PR still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants