Setup pre-push config #14718
Setup pre-push config #14718
Conversation
Demo
Jenkins 
demos.haus 
|
@petesfrench so far looks good (still reviewing), I just have an observation
|
|
@petesfrench the script doesn't detect errors in the new commits, just in the staged changes. Also, we should add a note to the readme about copying the file to |
|
@samhotep Good suggestions! I have made the changes to the script you suggested |
HACKING.md
Outdated
| ## Pre-push hook | ||
| We has a pre-push hook that will run anytime you try to push changes. To get it to work you need to copy over the pre-push script to `.git/hooks`. This can be done with the following command: |
.github/hooks/pre-push
Outdated
| error_flag=1 | ||
| fi | ||
|
|
||
| if ! npx flake8 "${scss_files[@]}" && black --check --line-length 79 "${scss_files[@]}"; then |
There was a problem hiding this comment.
This should be sth like python_files, right?
There was a problem hiding this comment.
Do we support python files btw?
|
@samhotep It seems I managed to push some incomplete work, we should definitely be checking |
I'm afraid I can't take credit. |
|
@petesfrench @samhotep Thanks for this piece of work! Are there any updates on this PR? |
Done
.pre-commit-config.yamlQA
.pre-commit-config.yaml(JS, CSS, HTML, PYTHON)Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-19061
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines