Skip to content

feat: added nginx rate limiting to marketo #15035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
samhotep wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: added nginx rate limiting to marketo #15035

samhotep wants to merge 2 commits into from

Conversation

@samhotep
Copy link
Member

@samhotep samhotep commented Apr 24, 2025 •
edited
Loading

Done

  • Added rate limiting config for the /marketo/submit endpoint.
    • Limited to 1req/s
    • Allow a queue of 20 requests before returning 429

QA

  • Open the demo
  • Attempt to hit the rate limit using the handy hey tool by running
./hey_linux_amd64 -m POST -H "Content-Type: application/x-www-form-urlencoded" -d "formid=testratelimit&email=email@example.com&company=canonical" https://ubuntu-com-15035.demos.haus/marketo/submit
  • Once QA is done, I'll add the same limit to staging and production nginx configs as well

Issue / Card

Fixes WD-15861

Help

QA steps - Commit guidelines

@webteam-app
Copy link

webteam-app commented Apr 24, 2025

Demo

Jenkins

demos.haus

abhigyanghosh30
abhigyanghosh30 requested changes Apr 25, 2025
View reviewed changes
@petesfrench petesfrench self-requested a review May 26, 2025 11:09
@Onibenjo
Copy link
Contributor

Onibenjo commented Jun 18, 2025

Hey @samhotep @petesfrench

What's the status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhigyanghosh30 abhigyanghosh30 abhigyanghosh30 requested changes

@petesfrench petesfrench Awaiting requested review from petesfrench

Requested changes must be addressed to merge this pull request.

Assignees

@petesfrench petesfrench

Labels

Review: Code needed Review: QA needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@samhotep @webteam-app @Onibenjo @abhigyanghosh30 @petesfrench